Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask february release #98

Open
wants to merge 148 commits into
base: develop
Choose a base branch
from

Conversation

sasakalaba
Copy link

Changes in changelog.

gcetusic and others added 30 commits March 8, 2016 10:51
 - importing stormpath_config from a local repository (not available through
   pip)
 - commented out MoveApiKeyToClientAPIKeyStrategy (not yet implemented in
   stormpath_config)
 - fixed field mapping in app.config dict object
 - skipped all the tests that are broken due to partly implemented
   StormpathSettings class
	'moved init settings to manager because we need the manager settings'
	(c73eb55)

Updated test_settings.py.
Conflicts:
	requirements.txt
	setup.py
	'removed redundant settings -> defined in default config'
	(e7e1ad2)

Commented out STORMPATH_BASE_TEMPLATE config setting.
…mented the rest

Conflicts:
	flask_stormpath/__init__.py

Commented out StormpathSettigns.__contains__, current mapping breaks the code.
Conflicts:
	flask_stormpath/views.py

Removed field mapping and replaced with Resource.to_camel_case().
Conflicts:
	flask_stormpath/__init__.py

Updated test_settings.TestCheckSettings:

 - updated imports
 - updated check_settings method call
 - updated skipped test error messages
 - check_settings now validates data through the new StormpathSettings class.
 - assertRaises now called as 'with' context manager
 - added ConfigurationError message check
 - double form instantiation
   (this needs to be fixed A.S.A.P. !!)
 - added the AppWrapper for manipulating Accept
   headers when testing views
 - extended 'enabled/required' check with surname and middle name
 - optional_field properties are now collected through a for loop
 - replaced 'UNKNOWN' with 'Anonymous'
 - replaced form.data with data (since you cannot assign new values to
   form.data)
 - added tearDown to test_views (for deconstructing dynamically set
   StormpathForm attributes)
 - fixed data indentation
 - fixed redirect_url
 - fixed flash error message output
 - added setUp to TestLogin
 - ignoring html coverage report
Combined test_redirect_to_login_and_register_url and
test_redirect_to_register_url into one test, since they test
the same logic.
sasa.kalaba added 30 commits January 16, 2017 15:24
(These are already present in ValidateClientConfigStrategy.)
ValidateClientConfigStrategy makes sure that apiKey id and secret are always
present.
 - moved accept header and request json logic to request_processors.py
 - return form.hidden_tag in login template (and removed form.csrf_token)
   (hidden_tag checks for every hidden field, not just csrf fields)
 - CSRFProtection object is now passed to and activated in StormpathManager
   init method
 - csrf is now manually checked before every request
  - removed visible field attribute
  - removed organization field
  - also moved all config.setdefaults to a setdefault method
  - added create_social_directory
  >> moved create_social_directory to helpers
  >> now creating social directories on main setup
MoveStormpathSettingsToStormpathConfigStrategy name.
Conflicts:
	flask_stormpath/views.py
…into xy_backup

Conflicts:
	flask_stormpath/__init__.py
	flask_stormpath/context_processors.py
	flask_stormpath/forms.py
	flask_stormpath/models.py
	flask_stormpath/views.py
	setup.py
	tests/helpers.py
	tests/test_context_processors.py
	tests/test_decorators.py
	tests/test_settings.py
	tests/test_views.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants